Queue latency gauge (by queue name) #4
Conversation
| @@ -46,6 +48,10 @@ module Sidekiq | |||
| sidekiq_active_processes.set({}, stats.processes_size) | |||
| sidekiq_jobs_retry_count.set({}, stats.retry_size) | |||
|
|
|||
| ::Sidekiq::Queue.all.each do |queue| | |||
| sidekiq_jobs_latency.set({ queue: queue.name }, queue.latency) | |||
There was a problem hiding this comment.
I think we have to round the seconds value for better visibility 🤔
There was a problem hiding this comment.
I don't think we actually need any rounding
There was a problem hiding this comment.
I'm a bit concerned that we scan for queues twice (for sizes and latencies), but I don't see any method in Sidekiq API that will allow us avoid it (when you initializing Sidekiq::Stats queue sizes will be requested immediately anyway). And I don't want reinvent half of sidekiq's api.rb for now.
Anyway it should be fast enough to be okay.
lib/yabeda/sidekiq.rb
Outdated
| @@ -31,6 +31,8 @@ module Sidekiq | |||
| gauge :jobs_retry_count, comment: "The number of failed jobs waiting to be retried" | |||
| gauge :jobs_dead_count, comment: "The number of jobs exceeded their retry count." | |||
| gauge :active_processes, comment: "The number of active Sidekiq worker processes." | |||
| gauge :jobs_latency, comment: "The job latency: the delay of the job start time in seconds" | |||
There was a problem hiding this comment.
I think that original explanation of what is latency is a bit easier to understand:
https://github.com/mperham/sidekiq/blob/0352ca8fb541dec2caca886aa374e4cbb3c638d9/lib/sidekiq/api.rb#L254-L255
Also you can specify seconds in Yabeda API:
| gauge :jobs_latency, comment: "The job latency: the delay of the job start time in seconds" | |
| gauge :jobs_latency, unit: :seconds, comment: "Time in seconds since the oldest job in the queue was enqueued." |
| @@ -46,6 +48,10 @@ module Sidekiq | |||
| sidekiq_active_processes.set({}, stats.processes_size) | |||
| sidekiq_jobs_retry_count.set({}, stats.retry_size) | |||
|
|
|||
| ::Sidekiq::Queue.all.each do |queue| | |||
| sidekiq_jobs_latency.set({ queue: queue.name }, queue.latency) | |||
There was a problem hiding this comment.
I don't think we actually need any rounding
|
Metric comment and description are fixed |
Uses sidekiq internal queue latency