Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcuts support #40

Closed
websirnik opened this issue Oct 2, 2013 · 6 comments · Fixed by #432 or #435
Closed

Keyboard shortcuts support #40

websirnik opened this issue Oct 2, 2013 · 6 comments · Fixed by #432 or #435
Assignees
@daviferreira

Comments

@websirnik
Copy link
Contributor

  • Bold - Cmd+B
  • Italic - Cmd+I
  • Underline - Cmd+U
@Wikunia
Copy link

Wikunia commented Oct 23, 2013

+1

@ghost ghost assigned daviferreira Nov 7, 2013
@taraskuba
Copy link

+1

2 similar comments
@sathishmanohar
Copy link

+1

@nleush
Copy link

nleush commented Nov 29, 2013

+1

@j0k3r
Copy link
Contributor

j0k3r commented Jan 5, 2015

+1

This is working on Chrome, because I guess Chome know that you are inside a contentEditable node, so it handles keyboard shortcut properly. But it doesn't work on Firefox.

Any clues about that?
Should we use an external lib to handle shortcuts?

@R0cker
Copy link

R0cker commented Jan 22, 2015

It doesn't work in Safari either. Any clues?

petrjasek added a commit to petrjasek/medium-editor that referenced this issue Feb 17, 2015
@petrjasek
feat: implement keyboard shortcuts for commands
7f0fa9d 
you can specify key for a button and on keydown with ctrl
it will trigger its action

fix yabwe#40
@petrjasek petrjasek mentioned this issue Feb 17, 2015
Merged
petrjasek added a commit to petrjasek/medium-editor that referenced this issue Feb 18, 2015
@petrjasek
fix(shortcuts): let metaKey trigger shortcuts
b227e7f 
this should work better for mac users

fix yabwe#40
@petrjasek petrjasek mentioned this issue Feb 18, 2015
Merged
nysk pushed a commit to nysk/medium-editor that referenced this issue Aug 10, 2015
@petrjasek
feat: implement keyboard shortcuts for commands
f13891a 
you can specify key for a button and on keydown with ctrl
it will trigger its action

fix yabwe#40
nysk pushed a commit to nysk/medium-editor that referenced this issue Aug 10, 2015
@petrjasek
fix(shortcuts): let metaKey trigger shortcuts
437ea97 
this should work better for mac users

fix yabwe#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviferreira daviferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@daviferreira @nleush @j0k3r @sathishmanohar @websirnik @taraskuba @R0cker @Wikunia