Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode fragment as part of linkValidation #1257

Merged
merged 1 commit into from
Feb 5, 2017

Commits on Dec 9, 2016

  1. Don't encode fragment as part of linkValidation

    Fix for: yabwe#1237
    
    Previously URIs were split at a question mark to determine path and
    query components. This caused a problem when fragments were part of a
    link as they were deemed to be part of the query.
    
    This splits a URL at a ? and a # to get both components and does not
    encode the fragment. It did feel a little wrong not to encode the
    fragment at all as there some characters that should be encoded, however
    the encodeUriComponent method is too heavy handed for a fragment.
    kevindew committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    1168710 View commit details
    Browse the repository at this point in the history