RequestHeaders should be retrieved from the currentRequest
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLSession provides a mechanism for additional HTTP Header fields to be added to each URLRequest that manages via `URLSessionConfiguration.HTTPAdditionalHeaders` request headers should be retrieved from the currentRequest of the data task to observer these and other headers that iOS automatically sends.
ncnk
pushed a commit
to ncnk/Bagel
that referenced
this pull request
Jul 12, 2021
RequestHeaders should be retrieved from the `currentRequest`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined within #33, URLSession automatically adds additional HTTP Headers to requests that are not observed by bagel.
Currently
BagelRequestCarrier.mextractsallHTTPHeaderFieldsfrom the original request that is enqueued and not the current request that is transmitted over the network.It can be assumed this is to avoid logging anything after receiving an
HTTP 301/2/3redirect response, but a redirect will not cause any of theallHTTPHeaderFieldsto change so it is safe and preferred to log the headers from thecurrentRequest.To be completely transparent about redirects, Bagel could swizzle
@selector(_redirectRequest:redirectResponse:completion:);and log etc...