update to enable usage on windows #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannaly
requested changes
Dec 18, 2018
|
@amannaly the requested changes have been made |
|
@rfecher thank you for the changes. Looks like this change has surfaced a bug in close() call due to which the travis build is failing. I have added a fix for the bug. Could you please add the fix also to your PR so that the build can pass. Also Yahoo requires all external contributors to sign agree to this document. Could you please take a look and sign? |
|
@amannaly I pulled in your fix. I also signed the CLA. Thanks! |
|
@rfecher Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the other comment in this file referencing, it is known that this won't work in windows, and results in fatal exceptions https://grokbase.com/t/lucene/dev/1519kz2s50/recent-java-9-commit-e5b66323ae45-breaks-fsync-on-directory
It seems appropriate to allow for the situation where a file channel cannot be created on a directory because in that situation (Windows) fsync is not applicable either.