Moving the majority of the memory manager interface to the slice #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liran-funaro
reviewed
May 3, 2021
| public abstract AbstractSlice getDuplicatedSlice(); | ||
|
|
||
| // Reset all common not final fields to invalid state | ||
| public abstract void invalidate(); |
There was a problem hiding this comment.
I suggest using a default implementation here that will initialize the common values.
There was a problem hiding this comment.
So how the specific fields will be invalidated?
| * Sets everything related to allocation of an off-heap cut: a portion of a bigger block. | ||
| * Turns empty slice to an associated slice upon allocation. | ||
| */ | ||
| void associateBlockAllocation(int blockID, int offset, int length, long memAddress) { |
There was a problem hiding this comment.
- Why isn't it a part of
Slice's interface? - Could we associate a
Sliceto something other than a block allocation? If no, then this method can be renamed toassociate().
There was a problem hiding this comment.
This is not part of the Slice interface, because it is internal issue of the Memory Manager/Memory Allocator.
There was a problem hiding this comment.
There are also other "associations" like version which is not part of the block allocation. So leaving the name as is meanwhile.
Comment on lines
162
to
180
| /** | ||
| * The slices are ordered by their length, then by their block id, then by their offset. | ||
| * Slices with the same length, block id and offset are considered identical. | ||
| * | ||
| * Used for comparision of the slices in the freeList of memory manager, | ||
| * the slices are deleted but not yet re-allocated. | ||
| */ | ||
| @Override | ||
| public int compareTo(Slice o) { | ||
| int cmp = Integer.compare(this.length, o.length); | ||
| if (cmp != 0) { | ||
| return cmp; | ||
| } | ||
| cmp = Integer.compare(this.blockID, o.blockID); | ||
| if (cmp != 0) { | ||
| return cmp; | ||
| } | ||
| return Integer.compare(this.offset, o.offset); | ||
| } |
There was a problem hiding this comment.
Never mind. I just understand the difference between Slice and AbstractSlice. See comment regarding this class name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the majority of the memory manager interface to the slice. And some other adaptations.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.