added iterator remove, re-arranged some functions in InternaOakHash/Map/Basic #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anastasia Braginsky <anastas@yahoo-inc.com>
…ges tests to support OakHash iterators
liran-funaro
requested changes
Jan 2, 2022
sanastas
reviewed
Jan 4, 2022
Comment on lines
528
to
544
| @Override | ||
| public void remove() { | ||
| if (!isPrevIterStateValid()) { | ||
| throw new IllegalStateException("next() was not called in due order"); | ||
| } | ||
| BasicChunk prevChunk = getPrevIterState().getChunk(); | ||
| int preIdx = getPrevIterState().getIndex(); | ||
| boolean validState = prevChunk.readKeyFromEntryIndex(ctx.key, preIdx); | ||
| if (validState) { | ||
| K prevKey = getKeySerializer().deserialize(ctx.key); | ||
| InternalOakHash.this.remove(prevKey, null, null); | ||
|
|
||
|
|
||
| } | ||
|
|
||
| invalidatePrevState(); | ||
| } |
There was a problem hiding this comment.
I also do not see the reason for overriding
sanastas
approved these changes
Jan 12, 2022
| * advance state to the new position | ||
| * @return if new position found, return true, else, set State to null and return false | ||
| */ | ||
| protected boolean advanceState() { |
There was a problem hiding this comment.
In case something is changed in advance() it might need to affect advanceStream() as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.