Support on/off-heap entry array #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanastas
reviewed
Jan 6, 2022
# Conflicts: # core/src/main/java/com/yahoo/oak/EntryArray.java # core/src/main/java/com/yahoo/oak/EntryOrderedSet.java
sanastas
approved these changes
Mar 31, 2022
| @@ -70,25 +70,25 @@ public int fieldCount() { | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public void clear() { | |||
| UnsafeUtils.UNSAFE.setMemory(null, entriesAddress, buffer.capacity(), (byte) 0); | |||
| DirectUtils.UNSAFE.setMemory(null, entriesAddress, buffer.capacity(), (byte) 0); | |||
There was a problem hiding this comment.
For some interfaces DirectUtils has APIs like getLong or putLong and other interfaces are invoked referring to UNSAFE directly. Is it possible to move things like setMemory(...) to DirectUtils APIs?
| /** | ||
| * Abstraction for array of entries, where each entry has multiple fields (long). | ||
| */ | ||
| public interface EntryArrayInternal { |
There was a problem hiding this comment.
I liked more EntryArray as a name for the interface and EntryArrayInternal as a name for implementation. Is it possible to swap between the names?
| this.fields = additionalFieldCount + 2; // +2 for key and value references that always exist | ||
| this.entries = new long[entriesCapacity * this.fields]; | ||
| // +2 for key and value references that always exist | ||
| this.array = new EntryArrayHeap(entriesCapacity, additionalFieldCount + 2); |
There was a problem hiding this comment.
May be to put additionalFieldCount + 2 to a variable named fieldsPerEntryCounter, or to add some comment, to make it a bit clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.