Another novaentry #200
Another novaentry #200
Conversation
| if (!chunk.readKeyFromEntryIndex(ctx.tempKey, nextIndex)) { | ||
| continue; | ||
| } | ||
| if (!inBounds(ctx.tempKey)) { |
There was a problem hiding this comment.
inBounds() is invoking tooHigh and tooLow methods, where key comparison happens. First it sounds like here we can get the exception as well. Second, is the comparison in the tooHigh and tooLow methods using KeyUtils?
There was a problem hiding this comment.
I totally agree, this will be resolved in the next PR
There was a problem hiding this comment.
this will be fixed when changing the RuntimeException to Exception
| @@ -0,0 +1,277 @@ | |||
| /* | |||
| * Copyright 2020, Verizon Media. | |||
There was a problem hiding this comment.
I will continue review from here...
| if (!isValueRefValidAndNotDeleted(currIndex)) { | ||
| return false; | ||
| } | ||
| if (isKeyDeleted(new KeyBuffer(config.keysMemoryManager.getEmptySlice()), currIndex)) { |
There was a problem hiding this comment.
Can we use the ThreadContext here?
There was a problem hiding this comment.
I tried something else!
| @@ -225,7 +235,7 @@ private int getLastSortedEntryIndex(int sortedCount) { | |||
| int compareKeyAndEntryIndex(KeyBuffer tempKeyBuff, K key, int ei) { | |||
| boolean isAllocated = entryOrderedSet.readKey(tempKeyBuff, ei); | |||
There was a problem hiding this comment.
what we can do here ?
there is a situation where isAllocated will be false.
There was a problem hiding this comment.
This is exactly what needs to be compared via KeyUtils meaning providing the comparison as lambda to the memory manager (Nova). This method can be used only on minKey. Am I missing something?
There was a problem hiding this comment.
I am referring to the assert that comes directly after this line
assert isAllocated; do we want to remove it?
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.