Async cache setting #1736
Closed
Async cache setting #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2020 12:24
moizarafat
reviewed
Dec 28, 2020
...standalone/src/main/java/com/yahoo/elide/standalone/config/ElideStandaloneAsyncSettings.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 28, 2020 23:15
moizarafat
approved these changes
Jan 4, 2021
aklish
requested changes
Jan 5, 2021
| @@ -49,10 +53,13 @@ public AsyncAPIResult call() throws URISyntaxException, NoHttpResponseException | |||
| ElideResponse response = null; | |||
| log.debug("AsyncQuery Object from request: {}", this); | |||
| UUID requestUUID = UUID.fromString(queryObj.getRequestId()); | |||
| Map<String, List<String>> bypassCacheMap = new HashMap<String, List<String>>(); | |||
| bypassCacheMap.put("bypasscache", Arrays.asList(String.valueOf(service.isBypassCache()))); | |||
There was a problem hiding this comment.
Won't this always override the cache? I don't think this is the behavior that we want.
| if (queryObj.getQueryType().equals(QueryType.JSONAPI_V1_0)) { | ||
| response = executeJsonApiRequest(service.getElide(), user, apiVersion, requestUUID); | ||
| response = executeJsonApiRequest(service.getElide(), user, apiVersion, requestUUID, bypassCacheMap); |
There was a problem hiding this comment.
Instead of naming the variable bypassCacheMap, call it headers. It is a better reflection of what the map represents.
|
Closing since we are going to enable / disable caching based on Max cache size property, not on/off property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1537 (if appropriate)
Description
Add 'bypassCache' property to Async to enable/disable caching.
Motivation and Context
Enable / Disable Caching via Async properties
How Has This Been Tested?
Unit tests included.
Screenshots (if appropriate):
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.