fetcher: rename service.name to service.resource #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablopalacios
force-pushed
the
rename-name-to-resource
branch
2 times, most recently
from
97d7f79
to
8e7d128
Compare
redonkulus
reviewed
Nov 2, 2020
libs/fetcher.js
Outdated
| resourceName = fetcher.resource; | ||
| } else if (typeof fetcher.name !== 'undefined') { | ||
| if ('production' !== process.env.NODE_ENV) { | ||
| console.warn('"fetcher.name" is deprecated. Please rename it to "fetcher.resource".'); |
There was a problem hiding this comment.
This will be spammy in the console since we have many fetchers that use name. if we could only deprecate it once when the server starts, that would be better.
There was a problem hiding this comment.
I've moved this logic to Fetcher.middleware. I also added an array to control all the deprecated services definitions. In this way, it will be easier to spot services non compliant with the newer API.
pablopalacios
force-pushed
the
rename-name-to-resource
branch
from
c395fb6
to
4e97035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.