Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made operation timeout for memcached memdatacache configuration driven, #1090

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

michael-mclawhorn
Copy link
Contributor

Disabled blocking call on caching future.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

* @param bufSize the size of the queue
* @param operationTimeout The number of milliseconds to wait for timeout,
*/
TimeoutConfigurerBinaryConnectionFactory(int len, int bufSize, Long operationTimeout) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constructors are intentionally package private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Triggering
@cdeszaq
Copy link
Collaborator

cdeszaq commented Sep 29, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- fili-core/src/main/java/com/yahoo/bard/webservice/data/cache/TimeoutConfigurerBinaryConnectionFactory.java  1
         

See the complete overview on Codacy

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

77.3% 77.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_141) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants