Migrating builds to screwdriver from travis #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2020 16:32
Fixed by eliminating side effects.
michael-mclawhorn
changed the title
archolewa
reviewed
Nov 12, 2020
| DefaultSystemMetricProtocols.DEFAULT_PROTOCOL_DICTIONARY.putAll(BACKUP_DICTIONARY) | ||
| DefaultSystemMetricProtocols.STANDARD_PROTOCOLS.clear() | ||
| DefaultSystemMetricProtocols.STANDARD_PROTOCOLS.addAll(BACKUP_STANDARD_PROTOCOLS) | ||
| System.out.println("foo!") |
archolewa
approved these changes
Nov 12, 2020
will-lauer
approved these changes
Nov 12, 2020
screwdriver.yaml
Outdated
| - build: ./screwdriver/mvn-build.bash | ||
|
|
||
| master-commit: | ||
| requires: [~commit:master] |
There was a problem hiding this comment.
Generally, I would leave this as ~commit rather than ~commit:master. Screwdriver is already configured to point at a specific branch, so it seems reduntant to limit this to only the master branch. That means that you can't easily set up another screwdriver job to build another branch.
| for a in ${PUBLISH_WHITELIST}; do | ||
| if [[ ${GIT_BRANCH} = "origin/${a}" ]]; | ||
| then | ||
| WHITELISTED="true"; |
There was a problem hiding this comment.
given that you are in a for loop, you might was well break here when the condition is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.