logging for cache put failures #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2020 11:13
fili-core/src/main/java/com/yahoo/bard/webservice/logging/blocks/BardCacheInfo.java
Show resolved
Hide resolved
fili-core/src/main/java/com/yahoo/bard/webservice/logging/blocks/BardCacheInfo.java
Outdated
Show resolved
Hide resolved
michael-mclawhorn
requested changes
Nov 18, 2020
...src/main/java/com/yahoo/bard/webservice/web/responseprocessors/CacheV2ResponseProcessor.java
Outdated
Show resolved
Hide resolved
michael-mclawhorn
approved these changes
Nov 19, 2020
| @@ -105,6 +118,13 @@ public void processResponse(JsonNode json, DruidAggregationQuery<?> druidQuery, | |||
| ); | |||
| } | |||
| } catch (Exception e) { | |||
| //mark and log the cache put failure | |||
There was a problem hiding this comment.
This could use a test.
| * | ||
| * @return String representation of the Cksum | ||
| */ | ||
| public static String getMD5Cksum(String cacheKey) { |
There was a problem hiding this comment.
This would be better injected.
| @@ -148,6 +151,13 @@ public void writeCache( | |||
| ); | |||
| } | |||
| } catch (Exception e) { | |||
| //mark and log the cache put failure | |||
| CACHE_SET_FAILURES.mark(1); | |||
There was a problem hiding this comment.
This could use a test.
| if (SYSTEM_CONFIG.getBooleanProperty(WAIT_FOR_FUTURE, false)) { | ||
| return client.set(key, expirationInSeconds, value).get(); | ||
| } else { | ||
| return client.set(key, expirationInSeconds, value) != null; |
There was a problem hiding this comment.
These two paths could use a test to guarantee config results in the correct behaviors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.