Add first last any aggs #1141
Merged
Add first last any aggs #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddFirstLastAnyAggs
…ddFirstLastAnyAggs
michael-mclawhorn
requested changes
Feb 24, 2021
| VirtualColumnType getType(); | ||
|
|
||
| /** | ||
| * Get the expression of the virtual column in the response. |
There was a problem hiding this comment.
I suspect we should pull this from the interface, since the expression virtual column may be the only one that uses it.
Obviously I'm speculating since there's exactly one. But I like your instinct to make a type to avoid refactoring interfaces later.
|
|
||
| import org.joda.time.Interval; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Optional; | ||
| import java.util.*; |
There was a problem hiding this comment.
your IDE is globbing imports when it shouldn't. There's a setting for this in IDEA assuming that's what you're using.
michael-mclawhorn
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.