Implement BaseCompositePhysicalTable #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes seem fine. Rick and I discussed at some point whether or not we should take out the 'we'll calculate the grain for you' from the composite tables and replace it with only passing in an acceptable grain. |
cdeszaq
requested changes
Apr 14, 2017
| */ | ||
| public class BaseCompositePhysicalTable extends BasePhysicalTable { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(MetricUnionCompositeTable.class); |
| ) { | ||
| super( | ||
| name, | ||
| IntervalUtils.getCoarsestTimeGrain(physicalTables).orElseThrow(() -> { |
There was a problem hiding this comment.
As commented before, just take in the grain, don't compute it. A param will need to be added, and the javadoc for physicalTables likely needs to be updated as well.
| if (!physicalTables.stream() | ||
| .map(PhysicalTable::getSchema) | ||
| .map(PhysicalTableSchema::getTimeGrain) | ||
| .allMatch(grain -> grain.satisfiedBy(coarsestTimeGrain))) { |
There was a problem hiding this comment.
Can switch to a method reference for the new satisfies method on grain: coarsestTimeGrain::satisfies
| .map(PhysicalTableSchema::getTimeGrain) | ||
| .allMatch(grain -> grain.satisfiedBy(coarsestTimeGrain))) { | ||
| String message = String.format("There is no mutually satisfying grain among: %s for current table " + | ||
| "%s", |
There was a problem hiding this comment.
When wrapping, chop-wrap all parameters. That also means that the string doesn't need to be split either:
String message = String.format(
"There is no mutually satisfying grain among: %s for current table %s",
physicalTables,
name.asName()
);
cdeszaq
approved these changes
Apr 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #195 reveals a need to implement a common class between
PartitionCompositeTableandMetricUnionCompositeTable.