Adds a factory for building ResponseProcessor.
#663
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright 2018 Yahoo Inc. | ||
| // Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms. | ||
| package com.yahoo.bard.webservice.web.responseprocessors; | ||
|
|
||
| import com.yahoo.bard.webservice.application.ObjectMappersSuite; | ||
| import com.yahoo.bard.webservice.data.DruidResponseParser; | ||
| import com.yahoo.bard.webservice.data.HttpResponseMaker; | ||
| import com.yahoo.bard.webservice.web.DataApiRequest; | ||
| import com.yahoo.bard.webservice.web.PreResponse; | ||
|
|
||
| import rx.subjects.Subject; | ||
|
|
||
| /** | ||
| * A {@link ResponseProcessor} relies on things that are directly constructed at request time (i.e. the | ||
| * {@link DataApiRequest}). Therefore, we can't inject a `ResponseProcessor` directly. We can however inject a factory. | ||
| */ | ||
| public interface ResponseProcessorFactory { | ||
|
|
||
| /** | ||
| * Constructs a custom ResponseProcessor. | ||
| * | ||
| * @param apiRequest The current request | ||
| * @param responseEmitter Generates the response to be processed | ||
| * @param druidResponseParser Transforms a druid response into a {@link ResultSet} | ||
| * @param objectMappers Dictates how to format | ||
| * @param httpResponseMaker Crafts an HTTP response to be sent back to the user from a ResultSet or error message | ||
| * | ||
| * @return An object that handles parsing and post-processing of Druid requests | ||
| */ | ||
| ResponseProcessor build( | ||
| DataApiRequest apiRequest, | ||
| Subject<PreResponse, PreResponse> responseEmitter, | ||
| DruidResponseParser druidResponseParser, | ||
| ObjectMappersSuite objectMappers, | ||
| HttpResponseMaker httpResponseMaker | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Copyright 2018 Yahoo Inc. | ||
| // Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms. | ||
| package com.yahoo.bard.webservice.web.responseprocessors; | ||
|
|
||
| import com.yahoo.bard.webservice.application.ObjectMappersSuite; | ||
| import com.yahoo.bard.webservice.data.DruidResponseParser; | ||
| import com.yahoo.bard.webservice.data.HttpResponseMaker; | ||
| import com.yahoo.bard.webservice.web.DataApiRequest; | ||
| import com.yahoo.bard.webservice.web.PreResponse; | ||
|
|
||
| import rx.subjects.Subject; | ||
|
|
||
| /** | ||
| * Builds the default Druid response processor: {@link ResultSetResponseProcessor}. | ||
| */ | ||
| public class ResultSetResponseProcessorFactory implements ResponseProcessorFactory { | ||
|
|
||
| @Override | ||
| public ResponseProcessor build( | ||
| DataApiRequest apiRequest, | ||
| Subject<PreResponse, PreResponse> responseEmitter, | ||
| DruidResponseParser druidResponseParser, | ||
| ObjectMappersSuite objectMappers, | ||
| HttpResponseMaker httpResponseMaker | ||
| ) { | ||
| return new ResultSetResponseProcessor( | ||
| apiRequest, | ||
| responseEmitter, | ||
| druidResponseParser, | ||
| objectMappers, | ||
| httpResponseMaker | ||
| ); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob. not a blocker for this PR, but what if other
ResponseProcessorimplementations also need custom injection?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm, that's the whole idea of this PR? If somebody wants to inject their
own custom
ResponseProcessorthen they:CustomResponseProcessor.CustomResponseProcessorFactory.CustomResponseProcessorFactory.classThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean if they have non-empty constructors? Then they'd need to make their
constructor injectable so that HK2 can handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense