Uses addFactories rather than withFactories in the BinderFactory.
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- In the current behavior, if someone wants to add their own custom Metric Factory, and they naively overrwidw `getMetricFactories` to return `Optional.of(<Just-My-Factory>)`, Fili will *drop* all the current mappings and add just the one the user provided. So if the user wants to maintain the defaults, they have ot manually add them in `getMetricFactories`. This makes the most common use pattern (customers add a few custom metricMakers or dimension types, but otherwise wants the defaults available) very cumbersome. It is also, I would argue, very unintuitive. -- With the new behavior, custom metrics created by the user will be *added* to the already existing registry. So customers don't have to worry about losing the defaults because they added a few customs. If users want to override a default, they can register a new factory under the same name. If customers really want to drop all the defaults, well then they can override `getConfigurationLoader`. A bit cumbersome, but highly unlikely.
archolewa
force-pushed
the
use-add-for-reals
branch
from
574dab4
to
fb322d0
Compare
michael-mclawhorn
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- In the current behavior, if someone wants to add their own custom
Metric Factory, and they naively overrwidw
getMetricFactoriestoreturn
Optional.of(<Just-My-Factory>), Fili will drop all thecurrent mappings and add just the one the user provided. So if the user
wants to maintain the defaults, they have ot manually add them in
getMetricFactories.This makes the most common use pattern (customers add a few custom
metricMakers or dimension types, but otherwise wants the defaults
available) very cumbersome. It is also, I would argue, very unintuitive.
-- With the new behavior, custom metrics created by the user will be
added to the already existing registry. So customers don't have to
worry about losing the defaults because they added a few customs.
If users want to override a default, they can register a
new factory under the same name. If customers really want to drop all
the defaults, well then they can override
getConfigurationLoader. Abit cumbersome, but highly unlikely.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.