Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CJS default export #228

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Fix CJS default export #228

merged 3 commits into from
Apr 8, 2019

Conversation

roderickhsiao
Copy link
Collaborator

  1. Add default export to cjs module
  2. change export folder for es module to dist-es to better manage the folder.

kaesonho
kaesonho approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@kaesonho kaesonho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roderickhsiao roderickhsiao merged commit 097ff4e into yahoo:master Apr 8, 2019
@roderickhsiao roderickhsiao deleted the add-module-exports branch April 8, 2019 22:47
@roderickhsiao roderickhsiao mentioned this pull request Apr 8, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaesonho kaesonho kaesonho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roderickhsiao @kaesonho @tinder-rhsiao