enhance viewport detection performance #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaesonho
force-pushed
the
enhanceInitViewportDetection
branch
4 times, most recently
from
e5bd825
to
588fe78
Compare
|
👍 |
|
CLA is valid! |
| @@ -55,6 +55,7 @@ module.exports = function clickHandler (e) { | |||
| var isRedirectLink = isDefaultRedirectLink(target); | |||
| var isPreventDefault = true; | |||
| var props = self.props; | |||
| var followLink = props.followLink || props.follow; | |||
There was a problem hiding this comment.
Need to check whether props.followLink exists, before falling back to props.follow. i.e. if props.followLink is false, should just return false, instead of checking props.follow again.
kaesonho
force-pushed
the
enhanceInitViewportDetection
branch
from
06be3dd
to
588fe78
Compare
|
Hi @lingyan I updated, if there's no other concern I will merge this and release a new pkg today :) |
|
Go ahead 🚢, since @redonkulus has reviewed other changes :) |
kaesonho
force-pushed
the
enhanceInitViewportDetection
branch
from
813b7e7
to
ca85c80
Compare
kaesonho
added a commit
that referenced
this pull request
Jul 21, 2015
enhance viewport detection performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allcomponents, which might hurt the performance on page-init, change the implement here. For page init case, we recursively check viewport from the root, and break as long as the node is not in the viewport.fluxible-routerbetter@redonkulus @lingyan