update i13n model when props changes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaesonho
force-pushed
the
updatemodel
branch
2 times, most recently
from
4d58a4c
to
9d78cd9
Compare
| * @method updateModel | ||
| * @param {Object} newModel the new i13n model | ||
| */ | ||
| I13nNode.prototype.updateModel = function setParentNode (newModel) { |
There was a problem hiding this comment.
function name is incorrect
|
I didn't see you guys are reviewing so I squashed. |
|
CLA is valid! |
|
updated, remove set-immediate, keep the original flow |
|
LGTM, thanks! (might want to squash again though) :) |
| @@ -282,6 +282,20 @@ I13nNode.prototype.setParentNode = function setParentNode (parentNode) { | |||
| }; | |||
|
|
|||
| /** | |||
| * Update the i13n model | |||
| * @method updateModel | |||
| * @param {Object} newModel the new i13n model | |||
There was a problem hiding this comment.
Update comment to also allow function
|
one minor, 👍 |
kaesonho
added a commit
that referenced
this pull request
Aug 19, 2015
update i13n model when props changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redonkulus @kfay
Previously, to prevent modifying props, we use
object-assignformodelwhen we create ani13nNodehttps://github.com/yahoo/react-i13n/blob/master/src/libs/I13nNode.js#L31, the problem is it's never updated when we have props change.implement
componentWillUpdateand update i13n modelthanks @kfay for addressing this issue