pass bundle path to ycb for improved logging #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redonkulus
requested changes
Aug 31, 2020
| @@ -87,13 +87,13 @@ function contentsIsYCB(contents) { | |||
| * @param {array} contents The contents of the YCB file. | |||
| * @return {YCB} The YCB object. | |||
| */ | |||
| function makeYCB(config, dimensions, contents) { | |||
| function makeYCB(config, dimensions, contents, path) { | |||
There was a problem hiding this comment.
Can you update the code block above please?
redonkulus
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redonkulus Pass path when creating a YCB instance to use the improved logging from yahoo/ycb#71.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.