Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<after [amount] turns> seems to only apply to Global turns #11829

Closed
1 task done
mhoo40 opened this issue Jun 23, 2024 · 5 comments
Closed
1 task done

<after [amount] turns> seems to only apply to Global turns #11829

mhoo40 opened this issue Jun 23, 2024 · 5 comments
Labels

Comments

@mhoo40
Copy link

mhoo40 commented Jun 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.12.2-patch1

Describe the bug

the line "This Unit gains the [Shock II] promotion <after [10] turns>", which supposes to mean the unit will gain 'Shock II' 10 turns after being trained, but instead, it instantly gets the promotion because it just needs the game to go past turn 10.
Is there anyway for me to activate the UnitTriggerable based on the number of turns the unit has appeared in the game instead of the total number of turns the game has gone through?
Also, <every [amount] turns><for [amount] turns>, for example: "Can transform to [Musketman]<every [3] turns>", means every turns divisible by 3 this unit can transform, but only during that turn, so i want it to persevere a bit longer like <for [2] turns>, can it be done?

Operating System

Windows

@mhoo40 mhoo40 added the bug label Jun 23, 2024
@mhoo40 mhoo40 changed the title <after [amount] turns> seems to only applies to Global turns <after [amount] turns> seems to only apply to Global turns Jun 23, 2024
@yairm210
Copy link
Owner

The meaning of this conditional is "after X global turns", not a bug.
I agree it would be better phrased as "After turn [amount]", that's a change we can make

@hackedpassword
Copy link

If I may add an opinion - for grammatical clarity, "After turn number [x]" would clearly disambiguate the intent.

@SomeTroglodyte
Copy link
Collaborator

activate the UnitTriggerable based on the number of turns the unit has appeared in the game

Seems a very valid intent to me. Regrettably, we don't have the data. A MapUnit doesn't know how old it is. Maybe we should add that now, unused, so we can enable something like "Tadpole: Lives only 5 turns, then transforms into a Frog, whether it wants to or not" later, when most saves out there have the field...

"After turn number [x]"

Best version. And we should. Is that thing new enough nobody is using it yet so we can ditch all the deprecation effort?

@yairm210
Copy link
Owner

Nope, deprecation as usual

@mhoo40
Copy link
Author

mhoo40 commented Jun 24, 2024

"Tadpole: Lives only 5 turns, then transforms into a Frog, whether it wants to or not"

Yeah, i want to give my units special abilities like buff with cooldown or transformation for a few turns. Maybe i can just use the promotion system but its still very limited

@mhoo40 mhoo40 closed this as completed Jun 24, 2024
yairm210 added a commit that referenced this issue Jun 25, 2024
…t]", "before [amount] turns" -> "before turn number [amount]"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants