Tighten RulesetValidator for Terrain

[SomeTroglodyte]

This adds a warning for the exploit documented in HybridTileTech.md. Sorry, @hackedpassword, but at least you get a Warning only and a honorable mention in a source comment.

What happens with that exploit is - you get a tile where neither isLand nor isWater return true. Consequences for pathfinding seem nondestructive, but that unintentional un-planned-for situation is a time bomb - a regression trigger waiting to happen.

The idea in that Mod, however, should get a solution some day. "Bridges and Canals", if and when implemented in some form, may also solve some current problems - ships passing cities on hills take 2 movement for the step iirc, and so on. Something that allows ships and land units to share tile movement domains, both being able to cross without embarkation, if possible constructible (think panama canal), and optionally requiring a road to function as bridge? Something in a supported and unit-tested fashion.

[hackedpassword]

Well, let's at least set the record straight on what you're calling an exploit.

https://github.com/hackedpassword/Z2/blob/main/HybridTileTech.md

Not denying the technicality, but also concerned about this feature being removed, which Z2 was born from and relies upon. See Z2 Terrains.json: Bridges, CoastTile, OceanTile

I can understand this tech makes you coders nervous, hoping you'll find a way to make it supportable.

[SomeTroglodyte]

removed

We're not removing, but we need to clarify that we cannot guarantee any reliable behaviour when there's tiles violating the assumptions much of the code is based upon. We could choose different wording, but the severity needs to stay yellow - as in: unsupported.

[SomeTroglodyte]

I'd still like to start on "official" support of bridges, canals and terraforming (something CTP modding back then allowed), but every time I start looking at code, I lose courage... Not with my current health status.

[yairm210]

!
Are you okay with elaborating a bit about your health status?

[SomeTroglodyte]

Nothing compared to a moronic war. Just a foot immobilized. Worst are the anticoagulant injections I need to ram into myself. The next is due - hours ago 😨 😱 💉 👻

[hackedpassword]

current

I know exactly what you mean, and I have even more appreciation for your work.