-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods pointing to the "uncustomizable" classes. #2861
Conversation
The code looks fine but the pipelines are failing. Can you please fix it? Thanks! |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpstan is failing since the class is now being fetched from config. There is a chance that the package will fail if the config is wrong.
<file name="src/DataTables.php">
<error line="117" column="1" severity="error" message="Cannot call static method create() on mixed." />
<error line="130" column="1" severity="error" message="Cannot call static method create() on mixed." />
<error line="[14](https://github.com/yajra/laravel-datatables/actions/runs/3254410336/jobs/5342627471#step:5:15)3" column="1" severity="error" message="Cannot call static method create() on mixed." />
</file>
Maybe we can ignore this for it to pass? https://phpstan.org/user-guide/ignoring-errors#ignoring-in-code-using-phpdocs
/** @phpstan-ignore-next-line */
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Looks good and thanks for the hassle. Will review this as soon as I can. |
Released on v10.2.0, thanks a lot! 🚀 |
This allows people to use corresponding method calls like:
instead of needing to use the
make
method.Since only the
make
is using the classes fromdatatables.engines
, the code is not consistent.