Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case insensitive starts with search #2917 #2916

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: case insensitive starts with search #2917 #2916

merged 1 commit into from
Dec 6, 2022

Conversation

uchajk
Copy link
Contributor

@uchajk uchajk commented Dec 6, 2022

'search'         => [
        'smart'            => false,
        'multi_term'       => false,
        'case_insensitive' => true,
        'use_wildcards'    => false,
        'starts_with'      => true,
    ],

If this is the case, line 449 would return keyword% without converting it to lower case first. The change suggested in this request will first check the sensitivity, convert to lower if set to true, and then return lower("$keyword%").

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yajra yajra changed the title return after inspecting case insensitivity fix: case insensitive starts with search #2917 Dec 6, 2022
@yajra yajra merged commit 68fb2a6 into yajra:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants