[3.x] Fix Warning reset(): Calling reset() on an object is deprecated #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielrona @NBA707 this is similar to #107. May I request assistance of reviewing this PR? Thanks! |
|
It works with a function returning a record cursor. Thank you for doing this.
From: Arjay Angeles ***@***.***>
Date: Friday, May 20, 2022 at 5:59 PM
To: yajra/pdo-via-oci8 ***@***.***>
Cc: Warren Coykendall ***@***.***>, Mention ***@***.***>
Subject: Re: [yajra/pdo-via-oci8] Issue in reset() passing an object as parameter (PR #104)
@danielrona<https://github.com/danielrona> @NBA707<https://github.com/NBA707> this is similar to #107<#107>. May I request assistance of reviewing this PR? Thanks!
—
Reply to this email directly, view it on GitHub<#104 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMZC26GT5NG7IPJY7M2ZTLVLAYNDANCNFSM5VDFF2RQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
yajra
changed the title
|
Released on v3.2.3 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix yajra/laravel-oci8#692
Fix #108