Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use topkg to build and install the package. #7

Merged
merged 5 commits into from
Dec 10, 2015
Merged

Use topkg to build and install the package. #7

merged 5 commits into from
Dec 10, 2015

Conversation

yallop
Copy link
Owner

@yallop yallop commented Dec 10, 2015

This makes the build system much easier to maintain, and also fixes #5.

I'm not sure whether the map/readdir in pkg/build.ml is considered good practice for installing the examples (/cc @dbuenzli).

]
remove: [["ocamlfind" "remove" "higher"]]
depends: [ "ocamlfind" ]
depends: [ "ocamlfind" "ocamlbuild" ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the dependency on ocamlfind if you wish so (see below). Also at least add {build} tags on both dependencies.

@dbuenzli
Copy link

Also your META file:

version = "0.1.0"
description = "Library for higher-kinded programming"
archive(byte) = "higher.cma"
archive(native) = "higher.cmxa"
exists_if = "higher.cma"

is missing a few things. It should be:

version = "0.1.0"
description = "Library for higher-kinded programming"
archive(byte) = "higher.cma"
archive(byte,plugin) = "higher.cma"
archive(native) = "higher.cmxa"
archive(native,plugin) = "higher.cmxs"

(no need for the exists_if)

@yallop
Copy link
Owner Author

yallop commented Dec 10, 2015

Thanks for the suggestions, @dbuenzli! I've incorporated them in 5a3fba2, 4fb2cdc, b977461 and 93c33e5.

yallop added a commit that referenced this pull request Dec 10, 2015
Use topkg to build and install the package.
@yallop yallop merged commit 26a9e7c into master Dec 10, 2015
@yallop yallop deleted the topkg branch December 10, 2015 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native plugin support
2 participants