Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ocaml-migrate-parsetree #2

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Port to ocaml-migrate-parsetree #2

merged 2 commits into from
Feb 23, 2017

Conversation

let-def
Copy link

@let-def let-def commented Feb 23, 2017

This patch adds use of the newly release ocaml-migrate-parsetree library.
The purpose is to prevent ppx extensions breakage after a compiler upgrade by shadowing some compiler-libs modules with versioned ones.

The patch proceeds in two steps:

  • first remove use of Ast_mapper_class helper from ppx_tools (this one not being versioned)
  • add migrate-parsetree shadowing and entrypoints

@let-def
Copy link
Author

let-def commented Feb 23, 2017

The change in indentation makes the patch unnecessarily hard to read.

Appending ?w=1 makes github diff ignores whitespaces:
https://github.com/yallop/omonad/pull/2/files?w=1

@yallop
Copy link
Owner

yallop commented Feb 23, 2017

Thanks! This looks great.

@yallop yallop merged commit 227b482 into yallop:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants