Long Short Pair Support #88

snake-poison · 2021-11-01T08:43:52Z

Description of changes proposed in this pull request:

Modifies types to support alternatives to the EMP financial contracts
Modifications to the asset class to support LSP
Incorporates a mutlicall provider through the @0xsequence/multicall
Basic test to test LSPState
Removed the need to import our own abi as the UMA package contains all of the interfaces that we need so far.

Checks:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submission:

Have you successfully ran tests with your changes locally?
Have you lint your code locally prior to submission?

Changes to Existing Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, if applicable?

Modified Types and assets class to support FinancialContracts( LSP or EMP ) and Assets (LSP or EMP)

Uses multicall through the ethcall package to reduce the amount of network connections required to obtain state.

src/assetstest.json

src/types/assets.t.ts

src/lib/Asset.ts

Replaced ethcall package with @0xsequence/multicall Added cross-env package. Updated packages to their latest version except for typechain which could only be upgraded to 5.2.0 as ^6 breaks the type generation for the project.

…ll library provider.

into feat-add-lsp

hardhat.config.ts

package.json

src/lib/Asset.ts

ghost · 2021-11-05T11:06:31Z

@ElmoArmy I suggest to merge develop into feat-add-lsp.

# Conflicts: # package.json # src/lib/Asset.ts # yarn.lock

… a generated type from a local abi.

…y the newly merged util helpers.

…emoved them as some were causing type data loss.

snake-poison · 2021-11-05T19:12:31Z

@ElmoArmy I suggest to merge develop into feat-add-lsp.

You got it. Done in c2b0a78

…r api's that return price as float strings).

snake-poison added 3 commits October 30, 2021 00:01

Removed abi build script as we can now use @uma/contracts-node.

209c0a7

Modified Types and assets class to support FinancialContracts( LSP or EMP ) and Assets (LSP or EMP)

Ran formatter.

5e954cb

Initial commit to add LSP related features to the SDK.

3102655

Uses multicall through the ethcall package to reduce the amount of network connections required to obtain state.

ghost mentioned this pull request Nov 1, 2021

Develop #85

Closed

ghost reviewed Nov 1, 2021

View reviewed changes

src/assetstest.json Outdated Show resolved Hide resolved

ghost reviewed Nov 1, 2021

View reviewed changes

src/types/assets.t.ts Show resolved Hide resolved

Update comments

b1f0d91

snake-poison commented Nov 1, 2021

View reviewed changes

src/lib/Asset.ts Outdated Show resolved Hide resolved

snake-poison mentioned this pull request Nov 1, 2021

Pool / Incentivized Pool Interface update #89

Open

snake-poison added 5 commits November 3, 2021 19:58

Package updates and changes

0225723

Replaced ethcall package with @0xsequence/multicall Added cross-env package. Updated packages to their latest version except for typechain which could only be upgraded to 5.2.0 as ^6 breaks the type generation for the project.

Add support for testing sdk on the matic network and replaces multica…

19beec5

…ll library provider.

Removes abi files.

7d9b475

Ran script docgen to update documentation.

83e99ed

Merge branch 'feat-add-lsp' of https://github.com/yam-finance/synths-sdk

462294d

into feat-add-lsp

ghost reviewed Nov 4, 2021

View reviewed changes

hardhat.config.ts Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/lib/Asset.ts Outdated Show resolved Hide resolved

src/lib/Asset.ts Show resolved Hide resolved

snake-poison added 7 commits November 5, 2021 14:26

Merge remote-tracking branch 'origin/develop' into feat-add-lsp

c2b0a78

# Conflicts: # package.json # src/lib/Asset.ts # yarn.lock

Skipped invalid test for now.

3c9ca34

Updated helpers utils to use a generated factory from uma rather than…

1f4acbf

… a generated type from a local abi.

Removed unused references in assets and added dependencies required b…

e59959b

…y the newly merged util helpers.

Moved order of script to be closer to other similar scripts.

6122b36

Reverts issue in package.json

9b5e0b0

Explicit types were not more specific than implicit inferred types. R…

eb55f2b

…emoved them as some were causing type data loss.

snake-poison self-assigned this Nov 5, 2021

snake-poison added 3 commits November 5, 2021 16:12

Adds a helper function that takes care of rounding numbers (useful fo…

34bfd88

…r api's that return price as float strings).

Adds a helper function that takes care of rounding numbers (useful fo…

b86f75e

…r api's that return price as float strings).

Remove bad import.

210b45c

ghost mentioned this pull request Nov 8, 2021

Extract helper methods #90

Merged

5 tasks

Adds env for alchemy api keys.

5568835

snake-poison marked this pull request as ready for review November 8, 2021 12:51

Adds env for alchemy api keys in the CI Job test.

32b770f

snake-poison merged commit 50de22d into develop Nov 8, 2021

ethedev deleted the feat-add-lsp branch November 15, 2021 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Long Short Pair Support #88

Long Short Pair Support #88

snake-poison commented Nov 1, 2021 •

edited

Loading

ghost commented Nov 5, 2021 •

edited by ghost

Loading

snake-poison commented Nov 5, 2021

Long Short Pair Support #88

Long Short Pair Support #88

Conversation

snake-poison commented Nov 1, 2021 • edited Loading

Description of changes proposed in this pull request:

Checks:

New Feature Submission:

Changes to Existing Features:

ghost commented Nov 5, 2021 • edited by ghost Loading

snake-poison commented Nov 5, 2021

snake-poison commented Nov 1, 2021 •

edited

Loading

ghost commented Nov 5, 2021 •

edited by ghost

Loading