Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skills not saved between sessions #100

Closed
Macroft opened this issue Oct 9, 2020 · 2 comments · Fixed by #101
Closed

Skills not saved between sessions #100

Macroft opened this issue Oct 9, 2020 · 2 comments · Fixed by #101

Comments

@Macroft
Copy link
Contributor

Macroft commented Oct 9, 2020

If you enter a skill value and reload, it gets reset
@Macroft
Copy link
Contributor Author

Macroft commented Oct 9, 2020

The problem was that state.skills was undefined. It can be put in that state by loading my old profile.
A reset fixed it, but there was no 'You need to reset your profile'.
did something change that should have had a state.ver bump?

@Macroft
Copy link
Contributor Author

Macroft commented Oct 9, 2020

it might be worth mentioning that this means that all skill related loops fail

Macroft added a commit to Macroft/dumap that referenced this issue Oct 9, 2020
@Macroft
Fix yamamushi#100, pull version from html and check to see if state o…
980269e 
…bjects are empty
@Allen-Tainia Allen-Tainia linked a pull request Oct 9, 2020 that will close this issue
Fix #100, pull version from html and check to see if state objects ar… #101
Merged
Allen-Tainia added a commit that referenced this issue Oct 10, 2020
@Allen-Tainia
Merge pull request #101 from Macroft/_100_VersionFix
bcac8fe 
Fix #100, pull version from html and check to see if state objects ar…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #100, pull version from html and check to see if state objects ar… Macroft/dumap
1 participant
@Macroft