Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup crafiting calculation #113

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Macroft
Copy link
Contributor

@Macroft Macroft commented Oct 17, 2020

Eliminate need for simulation by tallying ingredients as a pool.
Prevents slowdown seen when several items were added to the crafting queue.

using objects as maps to avoid search loops

Fixes #112

@Allen-Tainia
Copy link
Collaborator

Allen-Tainia commented Oct 18, 2020

I really like the speed increase but there's something wrong going on with the final amount. for example, craft 1 warp drive:

  • the amount of sulfur pure need is -7 (time is negative too)
  • not all ores seem to be a multiple of 65 (or 585 for t1 batches). same kind of issue for the pures
  • no catalyst given (catalyst is needed)

@Macroft
I would like to chat with you when you get some free time because i'm looking at reworking parts here and there to make the calculator easier to follow and for some very needed updates at this point.
Message me via discord when you can (Velenka)

Eliminate need for simulation by tallying ingredients as a pool.
Prevents slowdown seen when several items were added to the crafting queue.

using objects as maps to avoid search loops
@Macroft Macroft force-pushed the Simplify/Speedup-Crafting-calculation branch from 714a461 to e75c947 Compare October 18, 2020 07:52
@Macroft
Copy link
Contributor Author

Macroft commented Oct 19, 2020

Made some tweaks, think everything is adding up correctly now. it would be nice if others checked with recipes they are familiar with.

@MasteredRed
Copy link
Collaborator

Aware that I'm not completely up to speed on the repo, but I saw this pull request and am confused. Is there a reason this hasn't been denied or accepted already?

@yamamushi
Copy link
Owner

@Macroft do you still need this merged? I don't know why I never got a notification for it :(

@Macroft
Copy link
Contributor Author

Macroft commented Jul 21, 2021 via email

@yamamushi
Copy link
Owner

Any ideas how to resolve this merge conflict?

@Macroft
Copy link
Contributor Author

Macroft commented Jul 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation Bogs Down when you add too many items
4 participants