-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup crafiting calculation #113
base: dev
Are you sure you want to change the base?
Speedup crafiting calculation #113
Conversation
I really like the speed increase but there's something wrong going on with the final amount. for example, craft 1 warp drive:
@Macroft |
Eliminate need for simulation by tallying ingredients as a pool. Prevents slowdown seen when several items were added to the crafting queue. using objects as maps to avoid search loops
714a461
to
e75c947
Compare
Made some tweaks, think everything is adding up correctly now. it would be nice if others checked with recipes they are familiar with. |
Aware that I'm not completely up to speed on the repo, but I saw this pull request and am confused. Is there a reason this hasn't been denied or accepted already? |
@Macroft do you still need this merged? I don't know why I never got a notification for it :( |
I have been distracted by other parts of life. If it still merges cleanly I
can tell you it drastically improves performance. But I may not be super
responsive to bug fixing.
…On Wed, Jul 21, 2021, 10:36 Will Navidson ***@***.***> wrote:
@Macroft <https://github.com/Macroft> do you still need this merged? I
don't know why I never got a notification for it :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF3JQX7QW6QYBGBQJ5OJ6DTY3ZPJANCNFSM4SUIAZFA>
.
|
Any ideas how to resolve this merge conflict? |
I will take a look at it tomorrow and let you know
…On Wed, Jul 21, 2021, 12:00 Will Navidson ***@***.***> wrote:
Any ideas how to resolve this merge conflict?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF3JQQOJQYZ3YW7BVV2ZKLTY4DKLANCNFSM4SUIAZFA>
.
|
Eliminate need for simulation by tallying ingredients as a pool.
Prevents slowdown seen when several items were added to the crafting queue.
using objects as maps to avoid search loops
Fixes #112