WIP: Enable all warnings (-Wall) in libyaml and tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's start warning on everything and we'll clean the warnings up as we go along.
There were several places in our test deconstructor where we were passing plain char[]s to functions expecting (yaml_char_t *)s. Since we will soon be forcing warnings to become errors, it makes sense to clean these up.
This should cover the remainder of the warnings found on the Travis CI OSX builder.
|
Applied. Pushed. Thanks! The test output is SOOO much nicer. |
sigmavirus24
pushed a commit
to sigmavirus24/libyaml
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's first enable all the warnings that each of our compilers will provide, then fix them, then turn them into errors so we don't add new warnings or regress the fixes in this PR.