Improve CMakeLists #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next step, integrate changes from #56 |
|
Question: What is the preferred CMake indent style ? or a space before the parenthesis I started to standardize on the version without the extra space |
jcfr
force-pushed
the
tweak-cmakelists
branch
4 times, most recently
from
2ab4966
to
e57b0e5
Compare
|
Associated email to |
sigmavirus24
suggested changes
May 27, 2017
.travis.yml
Outdated
| - clang | ||
| - gcc | ||
| before_install: | ||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo pip install scikit-ci-addons==0.15.0; sudo ci_addons travis/install_cmake 3.2.0; fi |
There was a problem hiding this comment.
Why are we sudo pip installing scikit-ci-addons? This is going to make our builds incredibly slow (the use of sudo)
|
@sigmavirus24 Thanks for the review.
Will do.
Will update to avoid using sudo. |
jcfr
force-pushed
the
tweak-cmakelists
branch
2 times, most recently
from
c03278a
to
994c9d4
Compare
|
@sigmavirus24 Et voila. Commit squashed, use of Thanks again for your help integrating these changes. |
New build options ----------------- * Add option BUILD_TESTING by default ON See https://cmake.org/cmake/help/v2.8.12/cmake.html#module:CTest * Simplify library type selection using standard option BUILD_SHARED_LIBS See https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html yamlConfig.cmake ---------------- * Generate and install yamlConfig.cmake, yamlConfigVersion.cmake and yamlTargets.cmake * Bump CMake version and explicitly associate include dirs with targets See https://cmake.org/cmake/help/v3.0/manual/cmake-buildsystem.7.html#include-directories-and-usage-requirements * Ensure building against libyaml using "find_package(yaml)" uses expected compile options: Set HAVE_CONFIG_H as private compile option, YAML_DECLARE_STATIC as public Testing ------- * Build all examples from "tests" directory CMake Best practices -------------------- * configure "config.h" based on version info found in CMakeLists.txt * Ensure buildsystem re-generation listing sources (best-practice) It is not recommended to use GLOB to collect a list of source files from the source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate. See https://cmake.org/cmake/help/v3.8/command/file.html Compilation warnings -------------------- * Set _CRT_SECURE_NO_WARNINGS if building using VisualStudio This will avoid warnings like this one: ``` C:\projects\libyaml\tests\run-emitter.c(268): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. ``` Continuous Integration ---------------------- * travis: Install CMake >= 3.x using scikit-ci-addons * Add comments to appveyor.yml and run-tests.sh
|
ping @sigmavirus24, this should be good to go |
sigmavirus24
approved these changes
Nov 30, 2017
|
Thanks for integrating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
LibYAMLConfig.cmakeallowing other CMake project to build against this projectcmake/config.hfileI anticipate to add more improvements, with the goal of simplifying the building of PyYAML wheels.