add -no-undefined to src/Makefile.am #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change building a dll with the mingw-w64 toolchain is impossible. All tests from make test-all succeed on native linux (Gentoo amd64 glibc default/linux/amd64/17.1/desktop gcc-7.2.0) Signed-off-by: Marty E. Plummer <hanetzer@protonmail.com>
|
@sigmavirus24, @hanetzer opened this because #85 got mysteriously closed and can't reopen. This now has the master after #86 was pushed. CI has passed. Can you approve it. We need to figure out mingw CI testing at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change building a dll with the mingw-w64 toolchain is
impossible. All tests from make test-all succeed on native linux
(Gentoo amd64 glibc default/linux/amd64/17.1/desktop gcc-7.2.0)
Signed-off-by: Marty E. Plummer hanetzer@protonmail.com