Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need for PTRDIFF_MAX #93

Closed
wants to merge 1 commit into from

Conversation

rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Jan 8, 2018

It's just being used to check for overflow, so check more
directly instead.

@rogpeppe rogpeppe force-pushed the 001-remove-ptrdiff branch 3 times, most recently from b77fff7 to fe51aaa Compare January 9, 2018 12:48
@Tux
Copy link

Tux commented Jan 11, 2018

I can verify that this patch works fine on the system where the issue was reported from (HP-UX 11.23 Itanium with GNU gcc)

@ingydotnet
Copy link
Member

Thanks @Tux. I'll go ahead and merge it.

It's just as easy to calculate the maximum value directly.
@ingydotnet
Copy link
Member

Merged. Pushed. Thanks!

I capitalized the first letter in the commit header.

@ingydotnet ingydotnet closed this Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants