Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #123

Merged
merged 3 commits into from
Mar 21, 2021
Merged

Fix tests #123

merged 3 commits into from
Mar 21, 2021

Conversation

jvanhoefer
Copy link
Member

No description provided.

@jvanhoefer jvanhoefer changed the base branch from main to develop March 19, 2021 18:36
@jvanhoefer
Copy link
Member Author

This should fix the issue with the missing tests for the SBML identifier/maths checks..., that @dilpath caught in PR #122

@jvanhoefer
Copy link
Member Author

Want to merge them before v022 sees the daylight ;)

dilpath
dilpath approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

yannikschaelte
yannikschaelte approved these changes Mar 19, 2021
View reviewed changes
tests/test_yaml2sbml.py Outdated Show resolved Hide resolved
tests/test_yaml2sbml.py Outdated Show resolved Hide resolved
jvanhoefer and others added 2 commits March 21, 2021 17:12
@jvanhoefer @yannikschaelte
Update tests/test_yaml2sbml.py
13d8395 
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@jvanhoefer @yannikschaelte
Update tests/test_yaml2sbml.py
d91a4e4 
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Mar 21, 2021 •
edited
Loading

Codecov Report

Merging #123 (d91a4e4) into develop (7a9cba2) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    87.15%   87.57%   +0.42%     
===========================================
  Files            6        6              
  Lines          475      475              
===========================================
+ Hits           414      416       +2     
+ Misses          61       59       -2
Impacted Files Coverage Δ
yaml2sbml/yaml2sbml.py 86.41% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9cba2...d91a4e4. Read the comment docs.

@jvanhoefer jvanhoefer merged commit d680fdc into develop Mar 21, 2021
@jvanhoefer jvanhoefer deleted the fix_tests branch March 21, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

@yannikschaelte yannikschaelte yannikschaelte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvanhoefer @codecov-io @yannikschaelte @dilpath