Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature validation in examples closes #51 #52

Merged
merged 6 commits into from
Jan 14, 2021

Conversation

jvanhoefer
Copy link
Member

  • Section regarding validation in both Lotka Volterra notebooks
  • Now there is no message (YAML file is valid ✅) any more, if the yaml validation is done inside yaml2sbml function, but only when the yaml validator is directly called.

@jvanhoefer jvanhoefer changed the title Feature validation in examples Feature validation in examples closes #51 Jan 14, 2021
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

In the "Lotka_Volterra_CLI.ipynb" notebook:

  • In the introductory text, two instances of "python" -> "Python

In the "Lotka_Volterra.ipynb" notebook:

  • Could switch from plotObservableTrajectories to plotStateTrajectories. Or use the plotting function with custom labels etc from your previous PR?
    • Currently, plotting the observables also plots some constant y_2 = 1 line. Where does this come from?
  • The parameters plot has negative values (I guess log10-scaled). Might be fixed with
fig, ax = plt.subplots()
visualize.parameters(result, ax=ax)
ax.set_xlabel('Logarithmically-scaled (base 10) parameter value')

@@ -26,6 +26,7 @@ def validate_yaml(yaml_file: str):
yaml_in = yaml.full_load(yaml_contents)

_validate_yaml_from_dict(yaml_in)
print('YAML file is valid ✅')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an option to suppress any messages? e.g. in PEtab, the linter returns nothing if validation was successful, unless the -v verbose flag is passed. This means if another program wants to determine whether a PEtab is valid, it can interpret the lack of a return message as success. Similarly, if a message by default is preferred in yaml2sbml, then an option to suppress success-related messages could provide the same convenience.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this would also mean that all messages like "Path to yaml..." and "Validating..." would need to be suppressed. In other programs, such messages are not displayed unless a verbose flag is passed.

Copy link
Member Author

@jvanhoefer jvanhoefer Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true, would be nice to have something like this :) I will address this in another PR :)

@jvanhoefer
Copy link
Member Author

Thank you @dilpath The first two points are easy to address, I changed them. The latter is a general unfortunate problem of pypesto. I hope, that this will be resolved in pypesto at some point this year... :)

@jvanhoefer jvanhoefer merged commit 4e67da4 into master Jan 14, 2021
@jvanhoefer jvanhoefer deleted the feature_validation_in_examples branch January 14, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants