-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup.cfg file instead of setup.py #87
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
========================================
Coverage 77.85% 77.85%
========================================
Files 5 5
Lines 429 429
========================================
Hits 334 334
Misses 95 95 Continue to review full report at Codecov.
|
Is there any benefit from requiring python > 3.7 or don't we just exclude users for no obvious reason? |
setup.cfg
Outdated
[options] | ||
install_requires = | ||
numpy >= 1.19.4 | ||
scipy >= 1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scipy is actually not used in the public API, but just in the examples...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know, my mistake! will move it back to the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it should be exactly as before, also again including python 3.6.
I think one can support 3.6, my take was rather "ok, when even the very basic modules like scipy drop 3.6, hardly any user will use 3.6 any more soon, so not worth taking the trouble here". But as some systems still run on 3.6, we can include it here. In that case the tests need to be subdivided though, e.g. if we add tests using AMICI, those need to be restricted to 3.7+. Most typical applications with PEtab or AMICI or an up-to-date scipy will only work for 3.7+ (and soon 3.8+, which introduces some nice language features). Usually, we only support the last two versions in our packages. If it is only about the conversion YAML -> SBML, that should work with 3.6. In summary: Both works. Which do you prefer? |
TBD: I think the dependencies should be tidied up afterwards, e.g. the test requirement is not used in the actual tests yet.