Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework asynchronous conversion #120

Closed
wants to merge 1 commit into from
Closed

Rework asynchronous conversion #120

wants to merge 1 commit into from

Conversation

tkrs
Copy link
Collaborator

@tkrs tkrs commented Dec 3, 2019

This reworks the clarity of APIs that execute CQL statements with an asynchronous conversion.

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #120 into master will decrease coverage by <.01%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #120      +/-   ##
=========================================
- Coverage    58.8%   58.8%   -0.01%     
=========================================
  Files          18      12       -6     
  Lines         318     284      -34     
  Branches       12       8       -4     
=========================================
- Hits          187     167      -20     
+ Misses        131     117      -14
Impacted Files Coverage Δ
examples/src/main/scala/Main.scala 0% <0%> (ø) ⬆️
...-effect/src/main/scala/agni/catsEffect/async.scala 0% <0%> (ø)
...r-util/src/main/scala/agni/twitterUtil/async.scala 0% <0%> (ø)
monix/src/main/scala/agni/monix/async.scala 0% <0%> (ø)
core/src/main/scala/agni/std/async.scala 100% <100%> (ø)
core/src/main/scala/agni/Cql.scala 50% <50%> (ø)
core/src/main/scala/agni/RowDeserializer.scala 27.27% <0%> (-18.19%) ⬇️
core/src/main/scala/agni/RowDecoder.scala 33.33% <0%> (-8.34%) ⬇️
core/src/main/scala/agni/Serializer.scala 93.05% <0%> (-1.39%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da14265...9494173. Read the comment docs.

@tkrs tkrs force-pushed the rework branch 4 times, most recently from 576453b to 12292e5 Compare December 5, 2019 08:53
@tkrs tkrs marked this pull request as ready for review December 7, 2019 17:08
@tkrs tkrs requested a review from yanana December 7, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants