Add support for optional secrets #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
force-pushed
the
add_mounter_and_optional_secrets
branch
from
203868f
to
a3fa9f3
Compare
nuwang
changed the title
|
Did you test it? Does IAM auth work from within K8s? |
|
I actually tested this with a public bucket with anonymous auth, and can confirm that it works. I can't see any reason why it wouldn't work with node/pod IAM, but I haven't tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow secrets to be optional when using IAM.
This PR makes the mounter configurable. (A configurable mounter is useful because we are trying to transition from s3fs to geesefs, and support both in the interim if possible)