Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantileTDigest #2553

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

ssmike
Copy link
Contributor

@ssmike ssmike commented Jun 25, 2018

RadixSort doesn't work on negative floats. So quantileTDigest doesn't work too.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@alexey-milovidov alexey-milovidov merged commit c7a305e into ClickHouse:master Jun 28, 2018
@alexey-milovidov
Copy link
Member

👍

@alexey-milovidov
Copy link
Member

Missing test.

@ssmike
Copy link
Contributor Author

ssmike commented Jun 28, 2018

dbms/src/Common/tests/radix_sort.cpp

alexey-milovidov added a commit that referenced this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants