Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAUSE/RESUME fixed #87

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

PAUSE/RESUME fixed #87

wants to merge 13 commits into from

Conversation

lowgear
Copy link
Contributor

@lowgear lowgear commented Dec 15, 2019

No description provided.

@lowgear
Copy link
Contributor Author

lowgear commented Dec 20, 2019

Please, review this :)

sources/config_reader.c Outdated Show resolved Hide resolved
sources/console.c Outdated Show resolved Hide resolved
sources/console.c Outdated Show resolved Hide resolved
sources/console.c Outdated Show resolved Hide resolved
@@ -325,6 +328,19 @@ od_router_attach(od_router_t *router, od_config_t *config, od_client_t *client,
od_server_t *server;
for (;;)
{
if (!route->rule->db_state->is_active)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any timeout for routing?
Also, we should check wether client disconnected during wait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address this a bit later.

Copy link
Contributor Author

@lowgear lowgear Jan 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've studied postgess messaging protocol for any timeouts given by the client and haven't found anything. Where should we get routing timeout? Did I miss such a timeout in client's requests or should this timeout be configurable just over the pooler's configs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking about waiting I wander if the way I implemented it is correct. At the bottom of the same for cycle some other waiting is implemented by means of od_route_wait. But I'm not sure what and why it actually does.

Also I don't know how to determine if the client is still connected.

@lowgear
Copy link
Contributor Author

lowgear commented Dec 26, 2019

I haven't tested the whole thing after issues fixing yet.

@lowgear
Copy link
Contributor Author

lowgear commented Jan 1, 2020

Now it's tested that with the given changes pause/resume still works.

@g0djan
Copy link
Contributor

g0djan commented Apr 3, 2020

Hi, you have a huge list of files with conflicts due to PR with formatting.
Steps for rebasing.

save files that were changed in your PR
git checkout master
git pull
git checkout
git rebase -i HEAD~0 --onto master(this line delete all your changes, don't forget to save it)
copy back saved files to the repository
format files: find ./ -type f ( -iname *.c -o -iname *.h -o -iname *.cpp -o -iname *.hpp ) -exec clang-format -style=file -i {} ;
git commit -am "Name of PR"
git push -f
If you have a questions or want my help you can ask me here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants