-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAUSE/RESUME fixed #87
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 816d459.
…er lock(but not sure what od_io_read_stop exactly does)
Please, review this :) |
@@ -325,6 +328,19 @@ od_router_attach(od_router_t *router, od_config_t *config, od_client_t *client, | |||
od_server_t *server; | |||
for (;;) | |||
{ | |||
if (!route->rule->db_state->is_active) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any timeout for routing?
Also, we should check wether client disconnected during wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will address this a bit later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've studied postgess messaging protocol for any timeouts given by the client and haven't found anything. Where should we get routing timeout? Did I miss such a timeout in client's requests or should this timeout be configurable just over the pooler's configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking about waiting I wander if the way I implemented it is correct. At the bottom of the same for cycle some other waiting is implemented by means of od_route_wait. But I'm not sure what and why it actually does.
Also I don't know how to determine if the client is still connected.
I haven't tested the whole thing after issues fixing yet. |
Now it's tested that with the given changes pause/resume still works. |
Hi, you have a huge list of files with conflicts due to PR with formatting. save files that were changed in your PR |
No description provided.