Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor encode.go #2

Closed
yanfali opened this issue Apr 17, 2013 · 0 comments
Closed

Refactor encode.go #2

yanfali opened this issue Apr 17, 2013 · 0 comments
Assignees
@yanfali

Comments

@yanfali
Copy link
Owner

yanfali commented Apr 17, 2013

  • Remove some repetition in the append
  • Use constants for the fixed strings
@ghost ghost assigned yanfali Apr 18, 2013
yanfali added a commit that referenced this issue Apr 18, 2013
@yanfali
Fix issue #2 refactor encode.go
3fa14c3 
- Clean up strings with constants
- refactor the switch to have a default
@yanfali yanfali closed this as completed Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanfali yanfali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yanfali