Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and problem description
The
test_with::env
andtest_with::no_env
macros fail to handle properly the following multiline env vars case:This is problematic since it interferes with rustfmt, i.e.,
cargo fmt
command automatically changes the long attribute lines in a multiline format.A possible workaround would be to annotate the test with the
#[rustfmt::skip]
so the macro attributes are not laid out in separate lines:Proposed solution
To fix the issue, I introduced the
sanitize_env_vars_attr(...)
function that properly handles the macro attributes arguments, removing any whitespace character and obtaining a slice containing the sanitized environment variable names.Additionally, I added some unit tests covering the
check_env_condition
,check_no_env_condition
, andsanitize_env_vars_attr
functions.