-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorFlow compatibility problems #67
Comments
Thank you very much for your support of our project. We also found the problem you reflected, but the high-frequency use of these functions throughout the project, the solution you provide will make the whole project appear more bloated, so we recommend using a higher version of tensorflow instead of doing so. Of course there may be better ways to solve this problem, such as encapsulating these functions. Thanks again. @TITAN-PyCompat |
@yangxue0827 Thanks for the reply. However, I just create another pull request to fix another kind of compatibility problem inducing API usage. For Before seeing this reply, I just made some patches for your code in another pr #68 . |
Why do you still insist on using a lower version of tf? @TITAN-PyCompat |
Dear developers,
I observed some TensorFlow api usage in you code that might lead to serious compatibility problems(like crash).
In api
tf.cond
, the parametertrue_fn
andfalse_fn
appeared in tf v1.2.0-rc0 and not existed in earlier version. The corresponding parameter isfn1
andfn2
in older version. If you use the new version parameter name to pass the value, it will crash in earlier version.Same problem happens to api
tf.concat
, parameteraxis
appears in tf v1.0.0. The older parameter is calledconcat_dim
in earlier version api. Crash also happens for earlier version.These problems can be fixed in pr #66
I judged the version and used parameter name to make it compatible on more versions.
Look forward to your reply!
@yangJirui @yangxue0827
Thanks!
The text was updated successfully, but these errors were encountered: