Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto passworfields to a component #19

Closed
yann-yinn opened this issue Oct 3, 2021 · 1 comment
Closed

Refacto passworfields to a component #19

yann-yinn opened this issue Oct 3, 2021 · 1 comment
Assignees
@yann-yinn
Labels
enhancement New feature or request

Comments

@yann-yinn
Copy link
Owner

Password field is becoming more and more complex, leading to duplicate code in several different forms.

  • confirmation field
  • icon to show / hide password
  • instructions for the password
  • strength meter is coming soon.

We should extract it to a adonis "component", and the use this component in all form using the password fields. (see this comment for more details on the component #18 (comment))
@yann-yinn yann-yinn added the enhancement New feature or request label Oct 3, 2021
@yann-yinn yann-yinn mentioned this issue Oct 3, 2021
Merged
@yann-yinn yann-yinn self-assigned this Oct 5, 2021
yann-yinn added a commit that referenced this issue Oct 5, 2021
@yann-yinn
refactor(password fields): reusable component for password field
f3d91fc 
see #18 (comment)

#19
@yann-yinn
Copy link
Owner Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yann-yinn yann-yinn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yann-yinn