By yanniboi: Added travis files to do codesniffer review. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanniboi
force-pushed
the
feature/add-tests
branch
2 times, most recently
from
cc06f71
to
ad87358
Compare
yanniboi
force-pushed
the
feature/submission_entity
branch
from
9511330
to
1704ebf
Compare
yanniboi
force-pushed
the
feature/add-tests
branch
3 times, most recently
from
278a419
to
834f3bc
Compare
|
I'm not familiar with how to properly handle having / managing a d.o project plus its mirror on github – it's kind of duplicating some stuff like test execution? But if we work here it makes sense to have pull requests checked so I'm not opposed to adding travis-ci integration. Only thing that caught my eye was that we still have field_group as dependency although we don't use it anymore. Besides that this is good to go! |
yanniboi
force-pushed
the
feature/add-tests
branch
from
32cddfd
to
a90699f
Compare
|
I'm fixing the git history maunally and forced pushing the branch to tidy things up. |
|
Removed field_group module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.