Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid string copy #4

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Avoid string copy #4

merged 2 commits into from
Jan 3, 2023

Conversation

yanns
Copy link
Owner

@yanns yanns commented Jan 3, 2023

#3 + using Cow<str> to avoid duplicating String.

Compared to main, perf are better:

Screenshot 2023-01-03 at 17 47 33

@yanns yanns merged commit 0433653 into main Jan 3, 2023
@yanns yanns deleted the avoid_string_copy branch January 3, 2023 16:49
@yanns yanns mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yanns