feat: 新增江苏银行e融支付 #1002
Merged
feat: 新增江苏银行e融支付 #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yansongda
reviewed
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
============================================
+ Coverage 97.40% 97.49% +0.08%
- Complexity 909 952 +43
============================================
Files 347 361 +14
Lines 6213 6456 +243
============================================
+ Hits 6052 6294 +242
- Misses 161 162 +1 ☔ View full report in Codecov by Sentry. |
yansongda
reviewed
Jun 17, 2024
yansongda
reviewed
Jun 18, 2024
tests/Provider/EpayTest.php
Outdated
| use Yansongda\Pay\Tests\TestCase; | ||
|
|
||
| /** | ||
| * @internal |
yansongda
reviewed
Jun 18, 2024
There was a problem hiding this comment.
这个文件是验签的，似乎比较重要，看看能否帮忙把未单测覆盖的部分也把场景列出来然后单侧覆盖一下？
|
麻烦帮忙看看刚刚另外两个点，其他看着应该没问题了，改完之后这周我 PR 进来。 PS： 如果有时间的话，麻烦帮忙把文档也补充下 |
你说的问题都已解决 |
added 3 commits
June 18, 2024 15:34
|
@carlin-rj 抱歉打扰，请问方便给下江苏银行的文档么？我这边正在准备合代码，现在正拉下来仔细系统的审核一下，发现 scan 目录下的各个文件都没有相应的文档注释 |
|
我优化了一下代码，麻烦看看为啥那个单测没有过，我感觉你以前写的那个单测有问题 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增江苏银行e融支付